Discussion:
[libvirt] [PATCH] [patch] docs: remove redundant words and blank lines
l***@uniudc.com
2018-11-16 01:27:21 UTC
Permalink
From: ZhiPeng Lu <***@uniudc.com>

Signed-off-by: ZhiPeng Lu <***@uniudc.com>
---
docs/formatdomain.html.in | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 8a23b78..de25ad3 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2835,7 +2835,6 @@
&lt;/source&gt;
&lt;target dev='sdb' bus='scsi'/&gt;
&lt;/disk&gt;
- &lt;/disk&gt;
&lt;disk type='network' device='lun'&gt;
&lt;driver name='qemu' type='raw'/&gt;
&lt;source protocol='iscsi' name='iqn.2013-07.com.example:iscsi-nopool/0'&gt;
@@ -5216,7 +5215,6 @@
&lt;virtualport&gt;
&lt;parameters instanceid='09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f'/&gt;
&lt;/virtualport&gt;
-
&lt;/interface&gt;
&lt;/devices&gt;
...</pre>
@@ -5709,8 +5707,7 @@ qemu-kvm -net nic,model=? /dev/null
&lt;host csum='off' gso='off' tso4='off' tso6='off' ecn='off' ufo='off' mrg_rxbuf='off'/&gt;
&lt;guest csum='off' tso4='off' tso6='off' ecn='off' ufo='off'/&gt;
&lt;/driver&gt;
- </b>
- &lt;/interface&gt;
+ </b>&lt;/interface&gt;
&lt;/devices&gt;
...</pre>

@@ -6212,7 +6209,7 @@ qemu-kvm -net nic,model=? /dev/null <b>&lt;route family='ipv4' address='192.168.122.0' prefix='24' gateway='192.168.122.1'/&gt;</b> <b>&lt;route family='ipv4' address='192.168.122.8' gateway='192.168.122.1'/&gt;</b>
&lt;/hostdev&gt;
-
+ ...
&lt;/devices&gt;
...
</pre>
--
1.8.3.1
l***@uniudc.com
2018-11-16 01:29:29 UTC
Permalink
From: ZhiPeng Lu <***@uniudc.com>

Signed-off-by: ZhiPeng Lu <***@uniudc.com>
---
docs/formatdomain.html.in | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 8a23b78..de25ad3 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2835,7 +2835,6 @@
&lt;/source&gt;
&lt;target dev='sdb' bus='scsi'/&gt;
&lt;/disk&gt;
- &lt;/disk&gt;
&lt;disk type='network' device='lun'&gt;
&lt;driver name='qemu' type='raw'/&gt;
&lt;source protocol='iscsi' name='iqn.2013-07.com.example:iscsi-nopool/0'&gt;
@@ -5216,7 +5215,6 @@
&lt;virtualport&gt;
&lt;parameters instanceid='09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f'/&gt;
&lt;/virtualport&gt;
-
&lt;/interface&gt;
&lt;/devices&gt;
...</pre>
@@ -5709,8 +5707,7 @@ qemu-kvm -net nic,model=? /dev/null
&lt;host csum='off' gso='off' tso4='off' tso6='off' ecn='off' ufo='off' mrg_rxbuf='off'/&gt;
&lt;guest csum='off' tso4='off' tso6='off' ecn='off' ufo='off'/&gt;
&lt;/driver&gt;
- </b>
- &lt;/interface&gt;
+ </b>&lt;/interface&gt;
&lt;/devices&gt;
...</pre>

@@ -6212,7 +6209,7 @@ qemu-kvm -net nic,model=? /dev/null <b>&lt;route family='ipv4' address='192.168.122.0' prefix='24' gateway='192.168.122.1'/&gt;</b> <b>&lt;route family='ipv4' address='192.168.122.8' gateway='192.168.122.1'/&gt;</b>
&lt;/hostdev&gt;
-
+ ...
&lt;/devices&gt;
...
</pre>
--
1.8.3.1
Erik Skultety
2018-11-19 09:08:01 UTC
Permalink
Firstly, no need to send the same patch twice. Also, if you sent a patch and
later realized that there's something to be added into it, please reply to the
original to let reviewers know they should wait for a second revision which
leads me to the next thing - this patch should have been sent with the -v2
prefix to reflect the aforementioned fact.

I added a short commit message and pushed the patch with:
Reviewed-by: Erik Skultety <***@redhat.com>

Loading...