Discussion:
[libvirt] [libvirt-python PATCH] Fix copy paste error on the version check value
John Ferlan
2018-11-20 18:59:16 UTC
Permalink
Signed-off-by: John Ferlan <***@redhat.com>
---

This one I'll push under the build/test breaker rule...

I hadn't "installed" the libvirt library with the API so when "testing"
the build I just removed the CHECK_VERSION lines... Of course when looking
at the CI results I still saw the fail... So I looked more closely and saw
the errors of my ways, <sigh>... Before pushing this, I did install the
libvirt API/library changes on my host and rebuilt "naturally" and got a
pass, so I sincerely hope I got this right for the CI test env.!

libvirt-override.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libvirt-override.c b/libvirt-override.c
index 349ac63..f7b2f6b 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -1679,7 +1679,7 @@ libvirt_virDomainPinIOThread(PyObject *self ATTRIBUTE_UNUSED,

#endif /* LIBVIR_CHECK_VERSION(1, 2, 14) */

-#if LIBVIR_CHECK_VERSION(4, 10, 4)
+#if LIBVIR_CHECK_VERSION(4, 10, 0)

static virPyTypedParamsHint virPyDomainSetIOThreadParams[] = {
{ VIR_DOMAIN_IOTHREAD_POLL_MAX_NS, VIR_TYPED_PARAM_ULLONG },
@@ -10039,7 +10039,7 @@ static PyMethodDef libvirtMethods[] = {
{(char *) "virDomainGetIOThreadInfo", libvirt_virDomainGetIOThreadInfo, METH_VARARGS, NULL},
{(char *) "virDomainPinIOThread", libvirt_virDomainPinIOThread, METH_VARARGS, NULL},
#endif /* LIBVIR_CHECK_VERSION(1, 2, 14) */
-#if LIBVIR_CHECK_VERSION(4, 10, 4)
+#if LIBVIR_CHECK_VERSION(4, 10, 0)
{(char *) "virDomainSetIOThreadParams", libvirt_virDomainSetIOThreadParams, METH_VARARGS, NULL},
#endif /* LIBVIR_CHECK_VERSION(4, 10, 0) */
{(char *) "virConnectListStoragePools", libvirt_virConnectListStoragePools, METH_VARARGS, NULL},
--
2.17.2
Loading...