Discussion:
[libvirt] [PATCH] rpc: Remove duplicate check from filter function return.
Julio Faracco
2018-11-14 17:49:00 UTC
Permalink
This is a simple removal of a duplicated check of the return of the
filter function. There is a nested conditional checking exactly the same
thing.

Signed-off-by: Julio Faracco <***@gmail.com>
---
src/rpc/virnetserverclient.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
index 97cf126f56..778cd1afc0 100644
--- a/src/rpc/virnetserverclient.c
+++ b/src/rpc/virnetserverclient.c
@@ -1288,8 +1288,7 @@ static virNetMessagePtr virNetServerClientDispatchRead(virNetServerClientPtr cli
if (ret < 0) {
virNetMessageFree(msg);
msg = NULL;
- if (ret < 0)
- client->wantClose = true;
+ client->wantClose = true;
break;
}
if (ret > 0) {
--
2.19.1
John Ferlan
2018-11-14 20:13:55 UTC
Permalink
Post by Julio Faracco
This is a simple removal of a duplicated check of the return of the
filter function. There is a nested conditional checking exactly the same
thing.
s/./ since commit c9ede1cf removed the (ret > 0) check condition./
Post by Julio Faracco
---
src/rpc/virnetserverclient.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: John Ferlan <***@redhat.com>

John

Loading...